feat: Add support for character_set_name with MSSQL Server #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwillsher
changed the title
|
@mattwillsher - thanks for the PR! would you mind updating with the latest changes from |
|
@bryantbiggs Done. |
bryantbiggs
approved these changes
Mar 11, 2021
|
Thank you for this, @mattwillsher ! v2.27.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
character_set_namefor MSSQL RDS instances.Motivation and Context
Without this value the default collation cannot be set on MSSQL RDS instances, which in turn affects database created without specifying a collation. Default collation may need to be changed as per client requirements
This PR addresses the outstanding changes in #216
Breaking Changes
This does not break anything - default remains "".
How Has This Been Tested?
Tested deploying a v15.0 Standard Edition server, with and without the value set.
Also tested in #216
Default collation was set as expected.