Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update example projects #298

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • update examples to use modules to setup supporting resources instead of relying on account level defaults which may not exist (i.e. - create a VPC to test vs trying to use default VPC which may not exist for some users)
  • update examples to use later database versions to avoid running into any EOL issues
  • validate all examples modified (except Oracle which does not include any changes at this time)

Motivation and Context

  • ensure that modules are working as intended and ready to be used to validate changes

Breaking Changes

  • no, only example changes, nothing that affects the module itself

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
  • tested by executing all modules that have been changed to validate changes

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about version ranges.

examples/complete-mssql/main.tf Outdated Show resolved Hide resolved
examples/complete-mssql/main.tf Outdated Show resolved Hide resolved
examples/complete-mysql/main.tf Outdated Show resolved Hide resolved
examples/complete-mssql/main.tf Outdated Show resolved Hide resolved
examples/s3-import-mysql/main.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko merged commit 5884803 into terraform-aws-modules:master Mar 8, 2021
@antonbabenko
Copy link
Member

Thanks, v2.23.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants