Use utf8mb4 in mysql examples #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utf8 only stores 3 bytes per char so is not proper utf8, utf8mb4 is the proper encoding to use in mysql
bryantbiggs
approved these changes
Mar 14, 2021
There was a problem hiding this comment.
ah yes, good ol MySQL where utf8 is not utf8! thanks @lboynton - @antonbabenko 👍🏼
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I thought it would be good to use the proper UTF8 encoding in the MySQL examples, just to educate people who may not be aware that MySQL's utf8 only stores 3 bytes per char so is not proper utf8. utf8mb4 is the proper UTF8 encoding to use in MySQL.
Motivation and Context
Just to help maybe one or two people who may end up using the utf8 encoding by mistake.
Breaking Changes
None
How Has This Been Tested?
I use this in my own terraform code.