Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support different tags per resource. #319

Merged
merged 5 commits into from
Mar 19, 2021

Conversation

ruben0626
Copy link
Contributor

@ruben0626 ruben0626 commented Mar 18, 2021

Description

Add new vars to support different tags per resource:

  • db_instance_tags
  • db_option_group_tags
  • db_parameter_group_tags
  • db_subnet_group_tags

Motivation and Context

Sometimes we need to add specific tags to DB instances for auditing and security reasons but we can't add the same tags to other resources because of the same reason.

Breaking Changes

N/A

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

variables.tf Outdated Show resolved Hide resolved
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the PR @ruben0626 - @antonbabenko 👍🏼

@bryantbiggs
Copy link
Member

oh shoot, didn't see the pre-commit check fail. @ruben0626 could you run pre-commit run -a on your changes please?

@ruben0626
Copy link
Contributor Author

oh shoot, didn't see the pre-commit check fail. @ruben0626 could you run pre-commit run -a on your changes please?

done: 96a113c

@antonbabenko antonbabenko merged commit e22d6e6 into terraform-aws-modules:master Mar 19, 2021
@antonbabenko
Copy link
Member

Thanks, @ruben0626 !

v2.34.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants