Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CI/CD to use stable terraform-docs release artifact and discoverable Apache2.0 license #332

Conversation

bryantbiggs
Copy link
Member

Description

Motivation and Context

  • Yesterdays update to terraform-docs has yet again broken the CI/CD checks because we are trying to query the latest releases rather than a specific release artifact from downloads section

Breaking Changes

  • No

How Has This Been Tested?

  • Documentation changes only, no source code changes

@antonbabenko
Copy link
Member

The changes look good and I REALLY hope we won't apply another fix when terraform-docs release a new version.

PS: We should discuss GH Actions, pre-commit-terraform, and terraform-docs once more in the near future.

PPS: I will merge this and all others in a few hours. I want to automate this process a bit more but currently offline :)

@antonbabenko antonbabenko merged commit 66336d9 into terraform-aws-modules:master May 1, 2021
@bryantbiggs bryantbiggs deleted the chore/update-repo-docs-checks branch May 2, 2021 01:01
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants