Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove check for is_mssql which is no longer valid #382

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix: Remove check for is_mssql which is no longer valid #382

merged 1 commit into from
Feb 17, 2022

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Feb 17, 2022 •
edited

Description

  • Remove check for is_mssql which is no longer valid

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    • I haven't tested this but it shouldn't be used any longer since there isn't a separate MSSQL instance resource; plan of complete-mssql looks correct

@antonbabenko
Copy link
Member

I have just compared settings for this repository and found out that "Workflow permissions" were not set to "read and write" as in other repositories.

Problem solved.

@antonbabenko antonbabenko merged commit f4481e6 into terraform-aws-modules:master Feb 17, 2022
antonbabenko pushed a commit that referenced this pull request Feb 17, 2022
@semantic-release-bot
chore(release): version 4.1.1 [skip ci]
1b3549f 
### [4.1.1](v4.1.0...v4.1.1) (2022-02-17)

### Bug Fixes

* Remove check for `is_mssql` which is no longer valid ([#382](#382)) ([f4481e6](f4481e6))
@antonbabenko
Copy link
Member

This PR is included in version 4.1.1 🎉

@bryantbiggs bryantbiggs deleted the fix/mssql branch February 17, 2022 16:39
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko Awaiting requested review from antonbabenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module wants to destroy all mssql instances
2 participants
@bryantbiggs @antonbabenko