Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for identifier_prefix #416

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Jul 6, 2022

Description

Add support for using identifier_prefix.

Motivation and Context

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for this @magreenbaum !

@bryantbiggs
Copy link
Member

@magreenbaum looks like you'll need to update your branch with whats on master currently, then we can merge

@bryantbiggs bryantbiggs merged commit 125c426 into terraform-aws-modules:master Jul 6, 2022
antonbabenko pushed a commit that referenced this pull request Jul 6, 2022
## [4.5.0](v4.4.0...v4.5.0) (2022-07-06)

### Features

* Add support for `identifier_prefix` ([#416](#416)) ([125c426](125c426))
@antonbabenko
Copy link
Member

This PR is included in version 4.5.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying identifier_prefix for DB instances
3 participants