Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support name_prefix in iam_role.enhanced_monitoring #418

Conversation

magreenbaum
Copy link
Member

Description

Add support for using name_prefix for the enhanced monitoring iam role.

Motivation and Context

Partially addresses #417.

One thing I did not do in this PR is make using the name_prefix default. Doing so would require current users to pass in monitoring_role_use_name_prefix = false to not change existing configurations if using current defaults.

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you @magreenbaum !

@bryantbiggs bryantbiggs merged commit 644d255 into terraform-aws-modules:master Jul 13, 2022
antonbabenko pushed a commit that referenced this pull request Jul 13, 2022
## [4.6.0](v4.5.0...v4.6.0) (2022-07-13)

### Features

* Support `name_prefix` in `iam_role.enhanced_monitoring` ([#418](#418)) ([644d255](644d255))
@antonbabenko
Copy link
Member

This PR is included in version 4.6.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants