Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for storage_throughput #453

Conversation

take-five
Copy link
Contributor

AWS recently added support for gp3 storage type, and Terraform AWS provider implemented this functionality as well in version 4.45.0.

Description

Add support for storage_throughput attribute and document support of gp3 storage type.

Motivation and Context

AWS recently added support for gp3 storage type in RDS: aws.amazon.com/about-aws/whats-new/2022/11/amazon-rds-general-purpose-gp3-storage-volumes

This will allow users of this module to use more cost-effective storage type in place of gp2 if they desire.

Closes #452

Breaking Changes

The required AWS provider is bumped to 4.45. This version is where the storage_throughput argument became available.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

bryantbiggs commented Dec 5, 2022

please raise all of the versions throughout the modules and examples to >= 4.45

@take-five take-five force-pushed the add-storage-throughput-support branch from 8bd5ee4 to dbce617 Compare December 5, 2022 13:57
@take-five
Copy link
Contributor Author

Updated

@take-five take-five force-pushed the add-storage-throughput-support branch from dbce617 to af1a7e3 Compare December 5, 2022 14:04
AWS recently [added support for `gp3` storage type][1], and Terraform
AWS provider [implemented][2] this functionality as well in version 4.45.0.

Closes terraform-aws-modules#452

[1]: https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-rds-general-purpose-gp3-storage-volumes/
[2]: hashicorp/terraform-provider-aws#27670
@take-five take-five force-pushed the add-storage-throughput-support branch from af1a7e3 to 8f91c9d Compare December 5, 2022 14:15
@bryantbiggs bryantbiggs merged commit d81bf1f into terraform-aws-modules:master Dec 5, 2022
antonbabenko pushed a commit that referenced this pull request Dec 5, 2022
## [5.2.0](v5.1.1...v5.2.0) (2022-12-05)

### Features

* Add support for `storage_throughput` ([#453](#453)) ([d81bf1f](d81bf1f))
@antonbabenko
Copy link
Member

This PR is included in version 5.2.0 🎉

@take-five take-five deleted the add-storage-throughput-support branch December 5, 2022 14:59
@take-five
Copy link
Contributor Author

Thank you! Sorry for silly spelling mistakes 😄

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for storage_throughput attribute
3 participants