fix: Ensure that passing values for option group with PostgreSQL does not cause errors #467
Conversation
… not cause errors
| @@ -93,7 +93,7 @@ module "db_instance" { | |||
| vpc_security_group_ids = var.vpc_security_group_ids | |||
| db_subnet_group_name = local.db_subnet_group_name | |||
| parameter_group_name = local.parameter_group_name_id | |||
| option_group_name = local.option_group | |||
| option_group_name = var.engine != "postgres" ? local.option_group : null | |||
There was a problem hiding this comment.
Why would you null it when you can define an actual option group? (honest question)
There was a problem hiding this comment.
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_WorkingWithOptionGroups.html
PostgreSQL does not use options and option groups. PostgreSQL uses extensions and modules to provide additional features. For more information, see Supported PostgreSQL extension versions.
| @@ -8,6 +8,7 @@ on: | |||
|
|
|||
| env: | |||
| TERRAFORM_DOCS_VERSION: v0.16.0 | |||
| TFLINT_VERSION: v0.44.1 | |||
There was a problem hiding this comment.
Using a version avoids a few GitHub API calls which is currently causing issues with some workflows. Looks like they might have changed some of the rates, not sure why this is now an issue but just using a version seems to resolve this
### [5.2.3](v5.2.2...v5.2.3) (2023-01-03) ### Bug Fixes * Ensure that passing values for option group with PostgreSQL does not cause errors ([#467](#467)) ([696acbb](696acbb))
|
This PR is included in version 5.2.3 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request