Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable db_parameter_group_name variable #47

Conversation

jordiclariana
Copy link
Contributor

If the variable not specify then use the db_parameter_group module
This mimics the work done in PR #38 about db_subnet_group_name

@mazzy89
Copy link

mazzy89 commented Mar 14, 2018

Could we have this reviewed? I have the use case where the parameter group already exists and I need to pass in as a variable rather than create a new one. It would be very useful. For me it looks fine the job done by @jordiclariana

@antonbabenko antonbabenko merged commit 495d966 into terraform-aws-modules:master Mar 14, 2018
@antonbabenko
Copy link
Member

v1.14.0 has been just released. Thank you for the PR and a nudge :)

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants