Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Oracle nchar_character_set_name #487

Merged
merged 1 commit into from
May 2, 2023

Conversation

ManuelMueller1st
Copy link
Contributor

@ManuelMueller1st ManuelMueller1st commented Mar 30, 2023

Description

Add support for Oracle nchar_character_set_name

Motivation and Context

We need to change this value to UTF8.

Breaking Changes

none

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 30, 2023
@bryantbiggs bryantbiggs changed the title feat: Add support for Oracle nchar_character_set_name feat: Add support for Oracle nchar_character_set_name May 2, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit c7fd6c5 into terraform-aws-modules:master May 2, 2023
8 checks passed
antonbabenko pushed a commit that referenced this pull request May 2, 2023
## [5.7.0](v5.6.0...v5.7.0) (2023-05-02)

### Features

* Add support for Oracle `nchar_character_set_name` ([#487](#487)) ([c7fd6c5](c7fd6c5))
@antonbabenko
Copy link
Member

This PR is included in version 5.7.0 🎉

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants