Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues passing option group options requiring settings #63

Closed
tfuser9 opened this issue Jun 14, 2018 · 4 comments
Closed

Issues passing option group options requiring settings #63

tfuser9 opened this issue Jun 14, 2018 · 4 comments

Comments

@tfuser9
Copy link

tfuser9 commented Jun 14, 2018

Samples in the readme include items such as:

options = [
{
option_name = "MARIADB_AUDIT_PLUGIN"
}
]

For options requiring settings related to the option name, attempting a number of combinations such as this fail:

options = [
{
option_name = "SQLSERVER_BACKUP_RESTORE"
option_settings {
name = "IAM_ROLE_ARN"
value = "${aws_iam_role.database_role.arn}"
}
}
]

results in:
Error: module.database.module.db_option_group.aws_db_option_group.this: "option.0.option_name": required field is not set

The above example was formatted in the same manner used for aws_db_option_group resources. Is there another format in which they should be used with the terraform-aws-rds module? perhaps an item for the readme or one/some of the examples provided.

@antonbabenko
Copy link
Member

I have updated example and README to show complete example - see this commit

@jeremy-balmos
Copy link

jeremy-balmos commented May 22, 2019

This same error seems to continue when you use an ARN with v1.28.0 as shown below

options = [
{
option_name = "SQLSERVER_BACKUP_RESTORE"
option_settings = [
{
name = "IAM_ROLE_ARN"
value = "${data.terraform_remote_state.database_management.this_sql_backup_role_arn}"
},
]
},
]

I am finding any variable in the value string results in the error noted originally, if it is a simple string no error results.

@esteban-angee
Copy link

Experience the exact same issue as @jeremy-balmos.

This fails with error module.bike_db.module.db_option_group.aws_db_option_group.this: "option.0.option_name": required field is not set

options = [
    {
      option_name = "SQLSERVER_BACKUP_RESTORE"

      option_settings = [
        {
          name  = "IAM_ROLE_ARN"
          value = "${module.iam.rds_s3_integration_role_arn}"
        },
      ]
    },
  ]

On the other hand passing the hard-coded ARN in the value lets me run the plan successfully. This issue should be reopened.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants