Allow create of parameter group with custom name #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
requested changes
Mar 8, 2019
modules/db_parameter_group/data.tf
Outdated
| @@ -0,0 +1,3 @@ | |||
| locals { | |||
There was a problem hiding this comment.
Please put locals in main.tf. No need for data.tf.
| @@ -1,8 +1,24 @@ | |||
| resource "aws_db_parameter_group" "this_no_prefix" { | |||
There was a problem hiding this comment.
Update https://github.com/terraform-aws-modules/terraform-aws-rds/blob/master/modules/db_parameter_group/outputs.tf to include aws_db_parameter_group.this_no_prefix resource also.
antonbabenko
approved these changes
Mar 10, 2019
|
Thanks @robinbowes ! v1.23.0 has been released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to create the parameter group with a custom name.
It adds a new parameter:
use_parameter_group_name_prefixwhich allow the user to specify manually whether or not to use a prefix with the parameter group name (default: true).If
use_parameter_group_name_prefixis false, andparameter_group_nameis not passed,identifieris used.I found I also needed to add the capability to set the parameter group description, since it can't be changed without deleting/recreating the group. Since the purpose of these changes is to allow me to import an existing, active parameter group, it's important to be able to do that without triggering a delete.