Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Remove deprecated EC2 classic fields removed in AWS provider v5.0 #86

Merged
merged 2 commits into from Jun 6, 2023
Merged

feat!: Remove deprecated EC2 classic fields removed in AWS provider v5.0 #86

merged 2 commits into from Jun 6, 2023

Conversation

matt-dancer-adwanted
Copy link
Contributor

@matt-dancer-adwanted matt-dancer-adwanted commented May 31, 2023 •
edited by bryantbiggs

Description

  • Remove deprecated EC2 classic fields removed in AWS provider v5.0
  • Raise AWS provider minimum supported version to v5.0
  • Update and validate example

Motivation and Context

Breaking Changes

  • Yes; provider minimum supported raised to v5.0 which removes the deprecated fields

@matt-dancer-adwanted
Remove cluster_security_groups attribute, as the aws_redshift_securit…
7f1dd4b 
…y_group resource has been removed, following the retirement of EC2-Classic.
@matt-dancer-adwanted matt-dancer-adwanted changed the title Remove cluster_security_groups attribute, as the aws_redshift_security_groups attribute, as the aws_redshift_security_group resource has been removed, following the retirement of EC2-Classic. Fix: Remove cluster_security_groups attribute, as the aws_redshift_security_groups attribute, as the aws_redshift_security_group resource has been removed, following the retirement of EC2-Classic. May 31, 2023
@matt-dancer-adwanted matt-dancer-adwanted changed the title Fix: Remove cluster_security_groups attribute, as the aws_redshift_security_groups attribute, as the aws_redshift_security_group resource has been removed, following the retirement of EC2-Classic. fix: Remove cluster_security_groups attribute, as the aws_redshift_security_groups attribute, as the aws_redshift_security_group resource has been removed, following the retirement of EC2-Classic. May 31, 2023
@matt-dancer-adwanted
Copy link
Contributor Author

I believe this relates to hashicorp/terraform-provider-aws#29480.

@brianpham
Copy link

Thanks for putting up a fix!

@brianpham
Copy link

@bryantbiggs Can you help review? Would love to have a fix so I don't need to pin my local AWS version

@bryantbiggs bryantbiggs changed the title fix: Remove cluster_security_groups attribute, as the aws_redshift_security_groups attribute, as the aws_redshift_security_group resource has been removed, following the retirement of EC2-Classic. feat!: Remove deprecated EC2 classic fields removed in AWS provider v5.0 Jun 6, 2023
bryantbiggs
bryantbiggs approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bryantbiggs bryantbiggs merged commit 41fc56a into terraform-aws-modules:master Jun 6, 2023
10 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 6, 2023
@semantic-release-bot
chore(release): version 5.0.0 [skip ci]
aba9422 
## [5.0.0](v4.0.3...v5.0.0) (2023-06-06)

### ⚠ BREAKING CHANGES

* Remove deprecated EC2 classic fields removed in AWS provider v5.0 (#86)

### Features

* Remove deprecated EC2 classic fields removed in AWS provider v5.0 ([#86](#86)) ([41fc56a](41fc56a))
@antonbabenko
Copy link
Member

This PR is included in version 5.0.0 🎉

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
4 participants
@matt-dancer-adwanted @brianpham @antonbabenko @bryantbiggs