feat: Added full_override_name override to disable adding domain name to record names #69
Conversation
…efix to the record name
dmitriy-lukyanchikov
changed the title
dmitriy-lukyanchikov
changed the title
|
I would rather ask a user to prepare the valid |
maybe we can add per record flag? I believe preparing the records means using some regexp to actually edit records, i think the way that is used in this module is unnecessary because terraform provider and aws understand both jsut names without domain and full domain name so there is no need to prepend the domain name at all right now so current implementation is a bit strange. But maybe i miss some logic here |
|
After small thinking, I think that having this flag on a per-record basis and making it backward-compatible may be a good option. Please make the changes in the example to show both options. |
OK, will do, thank you for understanding! |
|
ok it is done |
|
@antonbabenko can somebody review, please? |
|
Yes, I will do it later this week. Too busy with countless other tasks at the moment. |
antonbabenko
changed the title
## [2.7.0](v2.6.0...v2.7.0) (2022-05-27) ### Features * Added full_override_name override to disable adding domain name to record names ([#69](#69)) ([553a4e1](553a4e1))
|
This PR is included in version 2.7.0 🎉 |
|
I have updated the example a bit. It is working but there is still issue #59 that prevents examples from being 100% working. |
|
probably to fix it completely need to rework it completely and remove data resources at all. I can do it if you want |
|
You can try. Keep in mind backward compatibility or at least a decent migration path for existing use-cases for terraform and terragrunt users. |
ok will try |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
…efix to the record name
Description
add full_override_name override to disable adding domain name as a prefix to the record name
Motivation and Context
add possibility to read the exported dns file taht contains full names.
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request