Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added source_account for lambda_permission resource #135

Merged
merged 2 commits into from
Feb 10, 2022
Merged

feat: Added source_account for lambda_permission resource #135

merged 2 commits into from
Feb 10, 2022

Conversation

AlKapkone
Copy link
Contributor

@AlKapkone AlKapkone commented Feb 10, 2022 •
edited by antonbabenko

Fixes #134

antonbabenko
antonbabenko requested changes Feb 10, 2022
View reviewed changes
modules/notification/main.tf Outdated Show resolved Hide resolved
modules/notification/variables.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title feat: added source_account for lambda_permission resource feat: Added source_account for lambda_permission resource Feb 10, 2022
@antonbabenko antonbabenko merged commit e9f0fcc into terraform-aws-modules:master Feb 10, 2022
antonbabenko pushed a commit that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): version 2.14.0 [skip ci]
3ca2f30 
## [2.14.0](v2.13.0...v2.14.0) (2022-02-10)

### Features

* Added source_account for lambda_permission resource ([#135](#135)) ([e9f0fcc](e9f0fcc))

### Bug Fixes

* Changelog duplicate header ([#133](#133)) ([8d4d28e](8d4d28e))
@AlKapkone AlKapkone deleted the source_account_lambda branch February 10, 2022 14:14
@antonbabenko
Copy link
Member

This PR is included in version 2.14.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko Awaiting requested review from antonbabenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add source_account argument to lambda_permissions in s3_notification_module
2 participants
@AlKapkone @antonbabenko