feat: Add "deny incorrect kms key sse" bucket policy #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
requested changes
Jun 18, 2023
|
Hello @antonbabenko thanks for the feedback. I fixed the typos and text. For the "principals{}" it is mandatory you get an error when we remove them. Please could you re-check this PR? |
antonbabenko
approved these changes
Jun 19, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Jun 19, 2023
## [3.14.0](v3.13.0...v3.14.0) (2023-06-19) ### Features * Add "deny incorrect kms key sse" bucket policy ([#240](#240)) ([e0d5788](e0d5788))
|
This PR is included in version 3.14.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the possibility to specify a KMS key to use as requirement for uploading files.
Motivation and Context
See this issue #239
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request