feat: Allow Custom 'Name' Tag For SG #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sojinss4u
changed the title
|
Hi @sojinss4u ! I very much agree with this PR. Thanks a lot for it. v3.16.0 has been just released. It may break some people's code but it is easy to fix. |
Surely that means v4.0..0? |
|
It may break, but also may not. |
|
So, a Schrödinger's release? |
hoylemd
added a commit
to pixlee/terraform-aws-security-group
that referenced
this pull request
Oct 14, 2020
* upstream/master: Updated CHANGELOG chore: Fixed formatting feat: Allow custom Name tag for security group (terraform-aws-modules#187) Updated CHANGELOG feat: Add JMX and Node exporter TCP ports for Kafka (terraform-aws-modules#186) Updated CHANGELOG feat: aws-provider version bump to >= 2.42, < 4.0 (terraform-aws-modules#184) Updated CHANGELOG feat: Add support for Solr (terraform-aws-modules#181) Updated CHANGELOG feat: Added optional revoke_rules_on_delete functionality (required for EMR) (terraform-aws-modules#179) Updated CHANGELOG feat: Updated version requirements to support Terraform 0.13 (terraform-aws-modules#178) Updated CHANGELOG fix: Fixed MinIO rules formatting feat: Adding support for MinIO (terraform-aws-modules#174)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some use-cases where we need to set custom 'Name' tag for Security Group.
Eg: https://aws.amazon.com/blogs/security/how-to-automatically-update-your-security-groups-for-amazon-cloudfront-and-aws-waf-by-using-aws-lambda/
Above lambda script identify Msgs by looking at the name tag which needs to be set 'cloudfront_g / cloudfront_r'. Currently this is not possible as merge() function will give the second argument precedence over the first one.
From https://www.terraform.io/docs/configuration/functions/merge.html
If more than one given map or object defines the same key or attribute, then the one that is later in the argument sequence takes precedence.
Motivation and Context
Allow Custom Name Tags
Breaking Changes
None
How Has This Been Tested?
Tested locally by changing order in merge argument.