feat: Added Zabbix rules #255
Conversation
## [4.12.0](v4.11.0...v4.12.0) (2022-08-22) ### Features * Added Zabbix rules ([#255](#255)) ([d29295c](d29295c))
|
This PR is included in version 4.12.0 🎉 |
|
I am more than happy to contribute to the open source community, but can you please at least make me a co-author to this? |
|
You have forked this module inside https://github.com/MAARK organization, where I didn't have push access to push the fixed docs, so I have opened another PR and merged it with reference to the original PR. Thank you for the addition! |
|
hi @antonbabenko Just wondering why @bikeusaland did not get any attribute for his commit, ate the least a co authorship should happen |
|
In general, I agree it would be great to have the avatars of the contributors in the readme in all repositories. @sanguis Where do you think I could put @bikeusaland as a co-author? The commits are being squashed during the merge of this PR, and the As I wrote in the previous comment, when the fork belongs to an organization where I don't have push right, I have to make a new PR and add missing changes prior to the merge. This is the way it has been working here in github. I am open to suggestions on general improvements to the processes, so please don't hesitate an issue here - https://github.com/terraform-aws-modules/meta . |
|
Anton-
Here is how GitHub suggests you do co-authorship: https://github.blog/2018-01-29-commit-together-with-co-authors/.
Greg
… On Aug 23, 2022, at 6:49 AM, Anton Babenko ***@***.***> wrote:
In general, I agree it would be great to have the avatars of the contributors in the readme in all repositories.
@sanguis Where do you think I could put @bikeusaland as a co-author? The commits are being squashed during the merge of this PR, and the changelog.md is automatically generated from the commit messages during release.
As I wrote in the previous comment, when the fork belongs to an organization where I don't have push right, I have to make a new PR and add missing changes prior to the merge. This is the way it has been working here in github.
I am open to suggestions on general improvements to the processes, so please don't hesitate an issue here - https://github.com/terraform-aws-modules/meta .
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
Right, I am sorry that I have not included you in this. It was not on purpose :) We were updating the release process some time ago, and in the past (for a couple of years) it was important that the commit description was empty not to break the |
|
All good, It just helps me justify, getting the company to pay us to contribute. :) Create an issue and assign myself and or @bikeusaland |
|
terraform-aws-modules/meta#31 - here is an issue to remind us. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This adds the needed ports for Zabbix server, proxy and agent
Closes #253
Motivation and Context
We are trying to fully automate the install of Zabbix infrastructure and this will make it easier to open the needed ports
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request