Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for bug when updating description of a rule with protocol all #34

Merged
merged 5 commits into from
Jan 16, 2018
Merged

Workaround for bug when updating description of a rule with protocol all #34

merged 5 commits into from
Jan 16, 2018

Conversation

nazartm
Copy link
Contributor

@nazartm nazartm commented Jan 16, 2018

Error:

"Error updating security group rule description:
InvalidParameterValue: When protocol is ALL, you cannot specify
from-port."

Issue:
hashicorp/terraform-provider-aws#1920

Error:

"Error updating security group rule description:
InvalidParameterValue: When protocol is ALL, you cannot specify
from-port."

Issue:
hashicorp/terraform-provider-aws#1920
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please add "Known issues" section to README.md.

main.tf Outdated
@@ -111,14 +111,18 @@ resource "aws_security_group_rule" "ingress_with_self" {
resource "aws_security_group_rule" "egress_rules" {
count = "${var.create ? length(var.egress_rules) : 0}"

lifecycle {
"ignore_changes" = ["description"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove quotes from ignore_changes

main.tf Outdated
security_group_id = "${aws_security_group.this.id}"
type = "egress"

cidr_blocks = ["${var.egress_cidr_blocks}"]
ipv6_cidr_blocks = ["${var.egress_ipv6_cidr_blocks}"]
prefix_list_ids = ["${var.egress_prefix_list_ids}"]
description = "${element(var.rules[var.egress_rules[count.index]], 3)}"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this new line

@antonbabenko antonbabenko merged commit f4b4368 into terraform-aws-modules:master Jan 16, 2018
@antonbabenko
Copy link
Member

v1.12.0 is released. Thanks for the contribution!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants