Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make TGW routing creation optional #119

Merged
merged 1 commit into from
Dec 11, 2023
Merged

feat: Make TGW routing creation optional #119

merged 1 commit into from
Dec 11, 2023

Conversation

vitalis
Copy link
Contributor

@vitalis vitalis commented Oct 23, 2023 •
edited

Description

Adds ability to disable TGW Route Table / Routes / Associations / Propagations creation using the create_tgw_routes variable

Motivation and Context

Current implementation does not support the following architecture:
https://d2908q01vomqb2.cloudfront.net/5b384ce32d8cdef02bc3a139d4cac0a22bb029e8/2020/11/19/index.png

Breaking Changes

no

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@vitalis vitalis changed the title feat: make TGW routing creation optional feat: Make TGW routing creation optional Oct 23, 2023
@vitalis
Copy link
Contributor Author

vitalis commented Oct 23, 2023

@antonbabenko Please review

@vitalis
Copy link
Contributor Author

vitalis commented Nov 10, 2023

@antonbabenko
Will this module receive updates?

@github-actions GitHub Actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 11, 2023
@vitalis
Copy link
Contributor Author

vitalis commented Dec 11, 2023

@bryantbiggs, is it possible for you to review / approve this PR?

bryantbiggs
bryantbiggs approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it but it looks ok - thank you

@bryantbiggs bryantbiggs merged commit 1661dfa into terraform-aws-modules:master Dec 11, 2023
5 of 6 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 11, 2023
@semantic-release-bot
chore(release): version 2.11.0 [skip ci]
4084879 
## [2.11.0](v2.10.0...v2.11.0) (2023-12-11)

### Features

* Make TGW routing creation optional ([#119](#119)) ([1661dfa](1661dfa))
@antonbabenko
Copy link
Member

This PR is included in version 2.11.0 🎉

@vitalis
Copy link
Contributor Author

vitalis commented Dec 12, 2023

Thank you @bryantbiggs and thank you @antonbabenko for both accepting my PR and for creating such amazing modules that same we so much time
If you need any help like PR reviews / Testing / Adding features i'll be more then happy to contribute, I'm working with TF starting version 0.2 👻

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitalis @antonbabenko @bryantbiggs