Default Transit Gateway Route Table tags

[uo-thomas]

When setting enable_default_route_table_association=true or enable_default_route_table_propagation=true and passing in tgw_route_table_tags, 2 route tables get created. 1 that is set as the default route table that has the associations and/or propagations with no tags and another route table that is empty that is tagged correctly.

[stevie-]

We see issues with the new ec2_tag resource. It may be related to the VPC tags we set by default which interacts with ec2_tags. We pass in these tags to vpc and to this module via var.tags.

Terraform will perform the following actions:

  # module.tgw.aws_ec2_tag.this["Name"] will be created
  + resource "aws_ec2_tag" "this" {
      + id    = (known after apply)
      + key   = "Name"
      + value = "central"
    }

  # module.tgw.aws_ec2_tag.this["ops.company.cloud/config_path"] will be created
  + resource "aws_ec2_tag" "this" {
      + id    = (known after apply)
      + key   = "ops.company.cloud/config_path"
      + value = "central/aws/transit_gateway/projectname"
    }

  # module.tgw.aws_ec2_tag.this["ops.company.cloud/environment"] will be created
  + resource "aws_ec2_tag" "this" {
      + id    = (known after apply)
      + key   = "ops.company.cloud/environment"
      + value = "central"
    }

  # module.tgw.aws_ec2_tag.this["ops.company.cloud/project"] will be created
  + resource "aws_ec2_tag" "this" {
      + id    = (known after apply)
      + key   = "ops.company.cloud/project"
      + value = "projectname"
    }

  # module.tgw.aws_ec2_tag.this["ops.company.cloud/provisioner"] will be created
  + resource "aws_ec2_tag" "this" {
      + id    = (known after apply)
      + key   = "ops.company.cloud/provisioner"
      + value = "terraform"
    }

  # module.tgw.aws_ec2_tag.this["ops.company.cloud/tf_module"] will be created
  + resource "aws_ec2_tag" "this" {
      + id    = (known after apply)
      + key   = "ops.company.cloud/tf_module"
      + value = "/aws/transit_gateway"
    }

  # module.tgw.aws_ec2_tag.this["ops.company.cloud/tf_module_version"] will be created
  + resource "aws_ec2_tag" "this" {
      + id    = (known after apply)
      + key   = "ops.company.cloud/tf_module_version"
      + value = "master"
    }

Plan: 7 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.tgw.aws_ec2_tag.this["ops.company.cloud/tf_module_version"]: Creating...
module.tgw.aws_ec2_tag.this["Name"]: Creating...
module.tgw.aws_ec2_tag.this["ops.company.cloud/tf_module"]: Creating...
module.tgw.aws_ec2_tag.this["ops.company.cloud/project"]: Creating...
module.tgw.aws_ec2_tag.this["ops.company.cloud/config_path"]: Creating...
module.tgw.aws_ec2_tag.this["ops.company.cloud/environment"]: Creating...
module.tgw.aws_ec2_tag.this["ops.company.cloud/provisioner"]: Creating...

Error: error creating EC2 Tag (ops.company.cloud/provisioner) for resource (): error tagging resource (): InvalidParameterValue: Value ( null ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid
	status code: 400, request id: 42192f9f-1546-4714-b9b2-b5b4e948ef64

  on .terraform/modules/tgw/main.tf line 44, in resource "aws_ec2_tag" "this":
  44: resource "aws_ec2_tag" "this" {



Error: error creating EC2 Tag (Name) for resource (): error tagging resource (): InvalidParameterValue: Value ( null ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid
	status code: 400, request id: 47722b53-468e-44c8-9610-0a26991c6b41

  on .terraform/modules/tgw/main.tf line 44, in resource "aws_ec2_tag" "this":
  44: resource "aws_ec2_tag" "this" {



Error: error creating EC2 Tag (ops.company.cloud/environment) for resource (): error tagging resource (): InvalidParameterValue: Value ( null ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid
	status code: 400, request id: d65fdd37-0af3-4031-827a-c49de711d449

  on .terraform/modules/tgw/main.tf line 44, in resource "aws_ec2_tag" "this":
  44: resource "aws_ec2_tag" "this" {



Error: error creating EC2 Tag (ops.company.cloud/config_path) for resource (): error tagging resource (): InvalidParameterValue: Value ( null ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid
	status code: 400, request id: 63fb9bbc-5d84-4fd9-8d5c-d30493bb6712

  on .terraform/modules/tgw/main.tf line 44, in resource "aws_ec2_tag" "this":
  44: resource "aws_ec2_tag" "this" {



Error: error creating EC2 Tag (ops.company.cloud/tf_module_version) for resource (): error tagging resource (): InvalidParameterValue: Value ( null ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid
	status code: 400, request id: 0cd35ef2-43b4-4d63-b654-400af185c37b

  on .terraform/modules/tgw/main.tf line 44, in resource "aws_ec2_tag" "this":
  44: resource "aws_ec2_tag" "this" {



Error: error creating EC2 Tag (ops.company.cloud/project) for resource (): error tagging resource (): InvalidParameterValue: Value ( null ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid
	status code: 400, request id: 31953a46-9409-470c-98f1-fb3d848c83ff

  on .terraform/modules/tgw/main.tf line 44, in resource "aws_ec2_tag" "this":
  44: resource "aws_ec2_tag" "this" {



Error: error creating EC2 Tag (ops.company.cloud/tf_module) for resource (): error tagging resource (): InvalidParameterValue: Value ( null ) for parameter resourceId is invalid. Null/empty value for resourceId is invalid
	status code: 400, request id: c7cf1b53-a4c4-450d-9873-ce6e43976e53

  on .terraform/modules/tgw/main.tf line 44, in resource "aws_ec2_tag" "this":
  44: resource "aws_ec2_tag" "this" {

Can we consider a boolean switch to disable/enable these tags?

[mitchellrj]

Yes, we have the same issue as @stevie-, when tags is set but enable_default_route_table_association is set to false, we now get errors.

@tfhartmann @antonbabenko

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.