Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Terraform minimum supported version to v0.13.1 #68

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Mar 26, 2022

Description

  • Update Terraform minimum supported version to v0.13.1
  • Fix cross-account TGW sharing via RAM (see 120533a)
  • Re-order tag values to allow resource specific tags to override Name tag used (this change should be a no-op for users)
  • Formatting and code organization updates to align with current standards
  • Replace use of lookup() with try()
  • Fix examples to use VPC and subnets created by the examples rather than creating the VPCs but relying on the users account default VPC
  • Replace deprecated aws_subnet_ids data source in examples with aws_subnets
  • Update provider required version schema to use current format
  • Remove example data sources and use module outputs directly

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

@bryantbiggs bryantbiggs marked this pull request as ready for review March 26, 2022 15:08
@antonbabenko antonbabenko merged commit 4e8f9c9 into terraform-aws-modules:master Mar 26, 2022
antonbabenko pushed a commit that referenced this pull request Mar 26, 2022
## [2.6.0](v2.5.1...v2.6.0) (2022-03-26)

### Features

* Update Terraform minimum supported version to `v0.13.1` ([#68](#68)) ([4e8f9c9](4e8f9c9))
@antonbabenko
Copy link
Member

This PR is included in version 2.6.0 🎉

@antonbabenko
Copy link
Member

Good to see that you have some time for this module. I made it a long time ago and used it just on one project. Thanks!

@bryantbiggs bryantbiggs deleted the feat/update-terraform-version branch March 26, 2022 16:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants