Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added TGW mutlicast support #73

Merged
merged 3 commits into from
May 9, 2022

Conversation

alimakki
Copy link
Contributor

@alimakki alimakki commented May 4, 2022

Description

Add variable enable_multicast_support to configure TGW mutlicast enablement

Motivation and Context

Current module does not accept parameter to enable multicast.

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • Tested on a private staging environment on AWS

 - Add variable `enable_multicast_support` to configure TGW mutlicast enablement
@alimakki alimakki changed the title TGW mutlicast support feat: TGW mutlicast support May 4, 2022
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please update the minimum version of Terraform AWS provider in versions.tf to be 4.3.0? It will lead to a major release.

@antonbabenko antonbabenko changed the title feat: TGW mutlicast support feat!: Added TGW mutlicast support May 5, 2022
@alimakki
Copy link
Contributor Author

alimakki commented May 5, 2022

@antonbabenko thanks for the review!

I noticed that the AWS provider version in versions.tf is currently set to >= 4.4 - would you like it changed to >= 4.3.0 ? Also for the example modules?

@antonbabenko
Copy link
Member

@alimakki You are right. No need to touch versions.tf. I have fixed the docs, too.

@antonbabenko antonbabenko merged commit a4d569b into terraform-aws-modules:master May 9, 2022
antonbabenko pushed a commit that referenced this pull request May 9, 2022
## [2.8.0](v2.7.0...v2.8.0) (2022-05-09)

### Features

* Added TGW mutlicast support ([#73](#73)) ([a4d569b](a4d569b))
@antonbabenko
Copy link
Member

This PR is included in version 2.8.0 🎉

@antonbabenko antonbabenko changed the title feat!: Added TGW mutlicast support feat: Added TGW mutlicast support May 9, 2022
@alimakki
Copy link
Contributor Author

alimakki commented May 9, 2022

thanks @antonbabenko !

@alimakki alimakki deleted the multicast branch May 9, 2022 11:53
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants