Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create private_ipv6_egress routes only when having at least one private subnet #1062

Conversation

RunCor399
Copy link
Contributor

@RunCor399 RunCor399 commented Apr 8, 2024

Description

Private IPv6 Egress routes are now only created when having at least a private subnet

Motivation and Context

Version 5.7.1 of the module solved the issue #1058 by limiting the amount of IPv6 egress routes created to the amount of NAT gateways provisioned (hence to the amount of Route Tables created).

However the condition that regulates the number of IPv6 egress routes created doesn't check if the creation of any private subnet is actually wanted

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

how has this been tested and validated

@RunCor399
Copy link
Contributor Author

how has this been tested and validated

I have run the same example quoted in issue #1061 before and after my modification.

@wiseelf
Copy link
Contributor

wiseelf commented Apr 9, 2024

Maybe it makes sense to set create_egress_only_igw to false by default?

@RunCor399
Copy link
Contributor Author

RunCor399 commented Apr 9, 2024

Maybe it makes sense to set create_egress_only_igw to false by default?

I believe that since create_egress_only_igw is also used in the database_ipv6_egress route, setting it to false by default may cause problems when having a setup with database subnets and no private subnets (and viceversa). In the latter scenario create_egress_only_igw would have to be set to true, thus leading to the creation of routes for both private and db subnets

@bryantbiggs bryantbiggs merged commit 8701204 into terraform-aws-modules:master Apr 24, 2024
22 checks passed
antonbabenko pushed a commit that referenced this pull request Apr 24, 2024
## [5.7.2](v5.7.1...v5.7.2) (2024-04-24)

### Bug Fixes

* Create private_ipv6_egress routes only when having at least one private subnet ([#1062](#1062)) ([8701204](8701204))
@antonbabenko
Copy link
Member

This PR is included in version 5.7.2 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in function call for private_ipv6_egress in version 5.7.1
4 participants