Add AZ to nat gateway name #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.tf
Outdated
| @@ -139,7 +139,7 @@ resource "aws_nat_gateway" "this" { | |||
| allocation_id = "${element(aws_eip.nat.*.id, (var.single_nat_gateway ? 0 : count.index))}" | |||
| subnet_id = "${element(aws_subnet.public.*.id, (var.single_nat_gateway ? 0 : count.index))}" | |||
|
|
|||
| tags = "${merge(var.tags, map("Name", format("%s", var.name)))}" | |||
| tags = "${merge(var.tags, map("Name", format("%s-%s", var.name, element(var.azs, count.index))))}" | |||
There was a problem hiding this comment.
This will probably give the wrong result when AZs are listed not alphabetically and single_nat_gateway = true. Correct me if I am wrong.
There was a problem hiding this comment.
I'm pretty sure it would run fine. But the new change is more explicit and similar to the lines above.
There was a problem hiding this comment.
Yes, this looks better. Thanks.
felixb
force-pushed
the
nat-gateway-tags
branch
from
e4fad19
to
1da7b4e
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.