Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage Default Route Table under Terraform #69

Merged
merged 4 commits into from
Feb 9, 2018
Merged

Manage Default Route Table under Terraform #69

merged 4 commits into from
Feb 9, 2018

Conversation

lawliet89
Copy link
Contributor

So that the default route table will be named and tagged accordingly instead of being unnamed and untagged.

antonbabenko
antonbabenko reviewed Feb 6, 2018
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

Few comments... You are making normal aws_route_table, but you probably wanted to use aws_default_route_table.

Do you want to have aws_default_route_table together with aws_main_route_table_association despite the warning?

@lawliet89
Copy link
Contributor Author

lawliet89 commented Feb 6, 2018 •
edited
Loading

You're right. I'll change the PR to tag aws_default_route_table instead. I didn't realise that resource existed.

@lawliet89
Copy link
Contributor Author

@antonbabenko I've pushed the changes.

@antonbabenko
Copy link
Member

This change is not as small as it may seem because it reassigns default resources. I will test it during tomorrow and extend this PR a bit.

@antonbabenko
Copy link
Member

antonbabenko commented Feb 9, 2018 •
edited
Loading

v1.20.0 has been released.

@antonbabenko antonbabenko merged commit 2985eba into terraform-aws-modules:master Feb 9, 2018
@lawliet89 lawliet89 deleted the default-route-table branch February 9, 2018 11:18
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lawliet89 @antonbabenko