Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add enable_tunnel_lifecycle_control arguments #88

Merged
merged 4 commits into from
May 18, 2023

Conversation

visit1985
Copy link
Contributor

Description

This PR adds the tunnel1_enable_tunnel_lifecycle_control and tunnel2_enable_tunnel_lifecycle_control arguments.

Motivation and Context

This aligns this module with the changes in upstream provider (hashicorp/terraform-provider-aws#30706).

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@visit1985 visit1985 changed the title feat: add enable_tunnel_lifecycle_control arguments feat: Add enable_tunnel_lifecycle_control arguments May 7, 2023
@antonbabenko
Copy link
Member

Looks good. Could you also update the minimum version of Terraform AWS provider to be 4.66 in all versions.tf, since the feature you're adding in this PR is pretty recent?

@visit1985
Copy link
Contributor Author

@antonbabenko, sure. Here you go.

@antonbabenko antonbabenko merged commit 23dec42 into terraform-aws-modules:master May 18, 2023
11 checks passed
antonbabenko pushed a commit that referenced this pull request May 18, 2023
## [3.4.0](v3.3.0...v3.4.0) (2023-05-18)

### Features

* Add `enable_tunnel_lifecycle_control` arguments ([#88](#88)) ([23dec42](23dec42))
@antonbabenko
Copy link
Member

This PR is included in version 3.4.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants