feat: make sed and find commands portable between Linux (GNU) and Mac OS (BSD) #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanini-ciandt
requested review from
rjerrems,
gtsorbo and
a team
as code owners
This was
linked to
issues
Nov 30, 2023
…b.com:romanini-ciandt/terraform-example-foundation into feature/make-sed-and-find-compatible-with-mac
rjerrems
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues #984, #922
The goal of this PR is to make all the
sedandfindcommands portable between Linux (GNU) and Mac OS (BSD). Nowadays, Mac OS users have some issues with some params (more details at the linked issues).For
find: the issue is that GNU by default assumes that we want to run in the current path (or.), while in BSD we need to explicit pass the path (.) as input.For
sed -i: sed file in-place suggests a need for a backup file. In GNU, if the backup file is not explict provided, the original file is overwritten but for GNU the way to achieve this same behavior (no backup saved) is to provide a zero-length extension as parameter.References:
For
sed:For
find: