fix: alternative deployment methods minor issues fix #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanini-ciandt
requested review from
rjerrems,
gtsorbo and
a team
as code owners
…raform-example-foundation into bugfix/github-deploy
romanini-ciandt
changed the title
romanini-ciandt
changed the title
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
@apeabody @bharathkkb @gtsorbo Build is Green 🎉 |
|
@gtsorbo @apeabody @bharathkkb build with fixes is green |
bharathkkb
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
The goal of this PR is to avoid an
Argument list too longerror on GitHub alternative deploy method when the bash output is too large for github actions to handle.When the error happens?
The error is happening in the GH action that is triggered when the PR between plan branch and production branch is opened in 1-org step and the output is too large (too many characters).
Which is the fix implemented?
The fix uses a file to handle the large output and truncate the exhibition in order to limit the maximum characters. Also, it provides a hyperlink to the full action output in case the user wants to check.
In additional to that, a coupe of simple minor adjusts were made. First for a missing permission to SAs, second to correct the place of the providers in the file, third was an index being added to a Terraform Cloud resource usage and fourth to add a missing local in 1-org step.
References:
actions/github-script#266