Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/centralized network variable #665

Merged
merged 17 commits into from
Apr 4, 2022
Merged

Refactor/centralized network variable #665

merged 17 commits into from
Apr 4, 2022

Conversation

LuizSDCit
Copy link
Contributor

@LuizSDCit LuizSDCit commented Mar 25, 2022 •
edited

fixes #392

@LuizSDCit LuizSDCit marked this pull request as ready for review March 29, 2022 13:53
@LuizSDCit LuizSDCit requested review from a team, rjerrems and bharathkkb as code owners March 29, 2022 13:53
bharathkkb
bharathkkb reviewed Mar 29, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LuizSDCit

3-networks/envs/development/main.tf Outdated Show resolved Hide resolved
3-networks/modules/base_env/main.tf Outdated Show resolved Hide resolved
3-networks/envs/development/main.tf Outdated Show resolved Hide resolved
3-networks/README.md Outdated Show resolved Hide resolved
3-networks/README.md Outdated Show resolved Hide resolved
3-networks/README.md Outdated Show resolved Hide resolved
3-networks/modules/base_env/interconnect.auto.tfvars.example Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit cdb97bf into terraform-google-modules:master Apr 4, 2022
@release-please release-please bot mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce params within network envs and create common baseline env
2 participants
@LuizSDCit @bharathkkb