-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add granular service accounts #724
feat!: add granular service accounts #724
Conversation
…tions.get' permission
The linter check never updated, so I just triggered a new run. |
The lint-tests passed, I'm not sure why the check isn't updating in GH. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor comment
* limitations under the License. | ||
*/ | ||
|
||
variable "parent_type" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful! Lets upstream this (as a follow up) to https://github.com/terraform-google-modules/terraform-google-iam/tree/master/modules. IIRC we need this in bootstrap too or possible other blueprints.
Fixes #679
Fixes #677
Fixes #344