-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: split network step #735
feat!: split network step #735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Hub & Spoke Transitivity module
should be removed from the dual svpc version
there are also some fixes on the readme and shared.auto.example.tfvars
files in the Hub and Spoke version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mauro-cit
We can also remove some of the conditional logic we no longer need like in
terraform-example-foundation/3-networks-dual-svpc/modules/base_shared_vpc/variables.tf
Line 27 in 997d699
variable "mode" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a suggestion
Fixes #672
Fixes #671
Some notes about the changes done by this PR: