Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Configure bring your own service account in bootstrap #777

Merged
merged 34 commits into from
Aug 24, 2022

Conversation

daniel-cit
Copy link
Contributor

@daniel-cit daniel-cit commented Aug 9, 2022

@daniel-cit daniel-cit changed the title DRAFT: Configure bring your own service account DRAFT: Configure bring your own service account in bootstrap Aug 17, 2022
@daniel-cit daniel-cit marked this pull request as ready for review August 18, 2022 13:17
@daniel-cit daniel-cit changed the title DRAFT: Configure bring your own service account in bootstrap feat!: Configure bring your own service account in bootstrap Aug 18, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit , minor nits

0-bootstrap/cb.tf Outdated Show resolved Hide resolved
0-bootstrap/cb.tf Outdated Show resolved Hide resolved
Comment on lines 92 to 93
# source = "terraform-google-modules/bootstrap/google//modules/tf_cloudbuild_builder"
# version = "~> 6.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been released

0-bootstrap/cb.tf Outdated Show resolved Hide resolved
0-bootstrap/cb.tf Outdated Show resolved Hide resolved
0-bootstrap/cb.tf Outdated Show resolved Hide resolved
0-bootstrap/outputs.tf Outdated Show resolved Hide resolved
docs/TROUBLESHOOTING.md Show resolved Hide resolved
test/integration/bootstrap/bootstrap_test.go Outdated Show resolved Hide resolved
@daniel-cit daniel-cit self-assigned this Aug 23, 2022
@bharathkkb bharathkkb merged commit 015fe3d into terraform-google-modules:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1-org deploy with cloudbuild plan error: specify 'build.logs_bucket' (b) use the CLOUD_LOGGING_ONLY
2 participants