Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Essential Contacts #783

Merged
merged 33 commits into from
Sep 7, 2022
Merged

Enable Essential Contacts #783

merged 33 commits into from
Sep 7, 2022

Conversation

felipecrescencio-cit
Copy link
Contributor

Fix issue #683.

Enable Essential Contacts feature on step 1-org.

@felipecrescencio-cit
Essencial contacts first POC
b090793
@felipecrescencio-cit
Remove essential contacs from step 0-bootstrap
e3a470c
@felipecrescencio-cit
Essential Contacts docs
1fd7485
@felipecrescencio-cit
Setup variables
7cc5526
@felipecrescencio-cit
New feature essential contacts
ff24796
@felipecrescencio-cit
Fix integrated test var initialization
eacf52c
@felipecrescencio-cit
Enable Essential Contacts API
03a047b
@felipecrescencio-cit
Essential Contacs IAM role
7b9ada2
@felipecrescencio-cit
Essencial contacts first POC
d35e29e
@felipecrescencio-cit
Remove essential contacs from step 0-bootstrap
a196a8c
@felipecrescencio-cit
Essential Contacts docs
5bd0b85
@felipecrescencio-cit
Setup variables
5313ee6
@felipecrescencio-cit
New feature essential contacts
7948f2a
@felipecrescencio-cit
Fix integrated test var initialization
7c42df2
@felipecrescencio-cit
Enable Essential Contacts API
ead9ca0
@felipecrescencio-cit
Essential Contacs IAM role
a1be52a
@felipecrescencio-cit
Merge branch 'feature/enable-essencial-contacts' of https://github.co…
239bd9a 
…m/felipecrescencio-cit/terraform-example-foundation into feature/enable-essencial-contacts
@felipecrescencio-cit
Fix Essential Contacts role after BYOSA
e6082fe
@felipecrescencio-cit
Fix getting Org Admin group email
cc5198f
@felipecrescencio-cit
Add project-factory essential_contacts submodule example
9b58146
@felipecrescencio-cit
Comment explaning why transpose categories map
52efab2
@felipecrescencio-cit
Fix method to get categories from gcloud command
68d4d9e
@felipecrescencio-cit
Undo changes
29b6be4
bharathkkb
bharathkkb reviewed Aug 26, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felipecrescencio-cit

1-org/README.md Outdated Show resolved Hide resolved
1-org/envs/shared/essential_contacts.tf Outdated Show resolved Hide resolved
1-org/envs/shared/essential_contacts.tf Show resolved Hide resolved
1-org/envs/shared/essential_contacts.tf Show resolved Hide resolved
1-org/envs/shared/variables.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb mentioned this pull request Aug 26, 2022
Closed
daniel-cit
daniel-cit requested changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@daniel-cit daniel-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is necessary to add essentialcontacts.googleapis.com to the list of valid APIs at the policy library constraint serviceusage_allow_basic_apis.yam

terraform-example-foundation/policy-library/policies/constraints/serviceusage_allow_basic_apis.yaml

Lines 30 to 40 in 4bd03ca

services:
- "accesscontextmanager.googleapis.com"
- "admin.googleapis.com"
- "appengine.googleapis.com"
- "artifactregistry.googleapis.com"
- "bigquery-json.googleapis.com"
- "bigquery.googleapis.com"
- "billingbudgets.googleapis.com"
- "cloudapis.googleapis.com"
- "cloudasset.googleapis.com"
- "cloudbilling.googleapis.com"

daniel-cit
daniel-cit reviewed Sep 2, 2022
View reviewed changes
1-org/README.md
| gcp_network_viewer | Technical | Org Admins |
| gcp_platform_viewer | Product Updates and Technical | Org Admins |
| gcp_scc_admin | Product Updates and Security | Org Admins |
| gcp_security_reviewer | Security and Technical | Org Admins |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an empty line before ### Deploying with Cloud Build

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@felipecrescencio-cit felipecrescencio-cit self-assigned this Sep 3, 2022
@bharathkkb bharathkkb merged commit 86fcb2a into terraform-google-modules:master Sep 7, 2022
@release-please release-please bot mentioned this pull request Sep 7, 2022
Merged
@felipecrescencio-cit felipecrescencio-cit deleted the feature/enable-essencial-contacts branch September 8, 2022 12:48
@bharathkkb bharathkkb mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-cit daniel-cit daniel-cit requested changes

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees

@felipecrescencio-cit felipecrescencio-cit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felipecrescencio-cit @bharathkkb @daniel-cit