fix: add note about updating transitivity firewall rules in the Hub and Spoke network mode #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxi-cit
reviewed
Dec 7, 2022
| To enabled **Hub and Spoke** transitivity set the variable `enable_hub_and_spoke_transitivity` to `true`. | ||
|
|
||
| **Note:** The default `allow-transitivity-ingress` firewall rule will rise SCC findings because of the ingress allow all ports and protocols from the [Shared address space CIDR block](https://en.wikipedia.org/wiki/IPv4_shared_address_space) used in the rule. | ||
| Because of this, you should update the implemented network access controls between spokes with valid values for your environment through the [firewall functionality](./modules/transitivity/main.tf#L142) of the corresponding NVAs to make them more restrictive. |
There was a problem hiding this comment.
Do you expect the user to perform this action? is it optional?
Co-authored-by: Max Portocarrero CI&T <105444618+maxi-cit@users.noreply.github.com>
daniel-cit
changed the title
bharathkkb
reviewed
Dec 9, 2022
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
bharathkkb
approved these changes
Dec 10, 2022
BrianReevz
pushed a commit
to BrianReevz/terraform-example-foundation
that referenced
this pull request
Jun 16, 2023
…nd Spoke network mode (terraform-google-modules#906) * add note about updating transitivity firewall rules in the Hub and Spoke network mode * Apply suggestions from code review Co-authored-by: Max Portocarrero CI&T <105444618+maxi-cit@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com> Co-authored-by: Max Portocarrero CI&T <105444618+maxi-cit@users.noreply.github.com> Co-authored-by: Andrew Peabody <andrewpeabody@google.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add note about updating transitivity firewall rules in the Hub and Spoke network mode