Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change priority of 'allow-google-apis' firewall rules to prevent collision with the deny all rule #972

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: change priority of 'allow-google-apis' firewall rules to prevent collision with the deny all rule #972

merged 1 commit into from
Jun 8, 2023

Conversation

daniel-cit
Copy link
Contributor

This pull request changes the priority of the 'allow-google-apis' firewall rules to prevent collision with the deny all rule.
See priority order for firewall rules

A rule with a deny action overrides another with an allow action only if the two rules have the same priority.

@daniel-cit daniel-cit requested review from a team and rjerrems as code owners May 25, 2023 18:16
@bharathkkb bharathkkb merged commit 7205518 into terraform-google-modules:master Jun 8, 2023
5 checks passed
@release-please release-please bot mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniel-cit @bharathkkb