Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix missing Terraform module attribution #973

Merged
merged 1 commit into from
Jun 2, 2023
Merged

fix: Fix missing Terraform module attribution #973

merged 1 commit into from
Jun 2, 2023

Conversation

daniel-cit
Copy link
Contributor

This pull request adds missing Terraform module attribution in steps

  • 3-networks-dual-svpc
  • 3-networks-hub-and-spoke
  • 4-projects

And fixes the Terraform module attribution for 2-environments step

@daniel-cit daniel-cit requested review from a team and rjerrems as code owners June 2, 2023 00:58
apeabody
apeabody approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daniel-cit!

@apeabody apeabody merged commit d1d2973 into terraform-google-modules:master Jun 2, 2023
5 checks passed
@release-please release-please bot mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniel-cit @apeabody