Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade default terraform version #112

Merged
merged 1 commit into from
Jul 28, 2021
Merged

upgrade default terraform version #112

merged 1 commit into from
Jul 28, 2021

Conversation

ericyz
Copy link
Contributor

@ericyz ericyz commented Jul 28, 2021

No description provided.

@comment-bot-dev
Copy link

comment-bot-dev commented Jul 28, 2021 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

@ericyz ericyz force-pushed the feature/upgrade-tf-version branch from 2b2c406 to 1799c90 Compare July 28, 2021 04:46
@ericyz ericyz force-pushed the feature/upgrade-tf-version branch from 1799c90 to 1eeee92 Compare July 28, 2021 04:47
@morgante
Copy link
Contributor

Note this is a breaking change which will need an upgrade guide.

BREAKING CHANGE: Default Terraform version increased to v1.0.2.
BREAKING CHANGE: Default branch trigger changed from `master` to `main`.
BREAKING CHANGE: Default trigger location in Terraform state changed, see upgrade guide for details.

morgante
morgante reviewed Jul 28, 2021
View reviewed changes
modules/cloudbuild/main.tf
***********************************************/

resource "google_cloudbuild_trigger" "master_trigger" {
resource "google_cloudbuild_trigger" "main_trigger" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is worth the state migration - @bharathkkb, thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morgante since this a breaking change anyway we could provide a small upgrade guide with a state mv command to be inline with https://developers.google.com/style/inclusive-documentation#replace-or-write-around-non-inclusive-terms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't mind either approach.

@morgante morgante merged commit dac0483 into terraform-google-modules:master Jul 28, 2021
@ericyz ericyz deleted the feature/upgrade-tf-version branch August 7, 2021 09:08
@release-please release-please bot mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@bharathkkb bharathkkb bharathkkb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericyz @comment-bot-dev @morgante @bharathkkb