Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added variable for terraform service account #116

Merged
merged 1 commit into from
Aug 23, 2021
Merged

added variable for terraform service account #116

merged 1 commit into from
Aug 23, 2021

Conversation

imrannayer
Copy link
Contributor

Fixed #110

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

rjerrems
rjerrems approved these changes Aug 23, 2021
View reviewed changes
Copy link
Contributor

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI @bharathkkb

@rjerrems rjerrems merged commit b7b0090 into terraform-google-modules:master Aug 23, 2021
@release-please release-please bot mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjerrems rjerrems rjerrems approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Org SA should be configurable
3 participants
@imrannayer @comment-bot-dev @rjerrems