Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added capability to toggle create_project_sa #124

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

kwong
Copy link
Contributor

@kwong kwong commented Oct 3, 2021

fixes #109

@google-cla
Copy link

google-cla bot commented Oct 3, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@kwong
Copy link
Contributor Author

kwong commented Oct 3, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@kwong
Copy link
Contributor Author

kwong commented Oct 3, 2021

@googlebot I fixed it.

@bharathkkb
Copy link
Member

Thanks for the PR @kwong

@bharathkkb bharathkkb merged commit 0457e66 into terraform-google-modules:master Oct 14, 2021
@morgante
Copy link
Contributor

@bharathkkb @rjerrems This is an example of a case where we probably should just set the value to false instead of exposing it as a variable.

(Not a huge deal, just want to use it as an example.)

@bharathkkb
Copy link
Member

@morgante makes sense, I missed that from the issue. Opened #126 since we dont have a use for the PF SA anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 service accounts created in the seed project
4 participants