Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add explicit dependency for GCS service account #128

Merged
merged 2 commits into from
Oct 15, 2021
Merged

fix: add explicit dependency for GCS service account #128

merged 2 commits into from
Oct 15, 2021

Conversation

morgante
Copy link
Contributor

Fixes #122

@comment-bot-dev
Copy link

comment-bot-dev commented Oct 15, 2021 •
edited

Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this is a bug in core but workaround lgtm. We have an explicit depends_on in PF which should wait till google_project resolves along with the google_project.main.number which will always be computed.

@morgante morgante merged commit 62adacc into master Oct 15, 2021
@morgante morgante deleted the morgante-patch-3 branch October 15, 2021 16:12
@release-please release-please bot mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error 400: Unknown project id - Due to Dependency Issue
3 participants
@morgante @comment-bot-dev @bharathkkb