Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serviceusage api added in the default activate_apis (#10) #13

Merged

Conversation

bdelv
Copy link
Contributor

@bdelv bdelv commented Feb 5, 2020

Just adds serviceusage.googleapis.com in the default activated apis.

issue #10

Note: I still have an issue for the tests to all pass with linking the billing account but I don't think it is any relevant to this change.

@morgante morgante self-requested a review February 5, 2020 15:56
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please regenerate docs, as per contributing guide.

@bdelv
Copy link
Contributor Author

bdelv commented Feb 5, 2020

It doesn't seem to change any README

➜  terraform-google-bootstrap git:(serviceusage-api-default) make docker_generate_docs
docker run --rm -it \
		-v /Users/brice/dev/temp/terraform-google-bootstrap:/workspace \
		gcr.io/cloud-foundation-cicd/cft/developer-tools:0.6.0 \
		/bin/bash -c 'source /usr/local/bin/task_helper_functions.sh && generate_docs'
Generating markdown docs with terraform-docs
Working in . ...
Success!
Working in ./examples/cloudbuild_enabled ...
Success!
Working in ./examples/simple ...
Success!
Working in ./modules/cloudbuild ...
Success!
Skipping ./test/fixtures/cloudbuild_enabled because README.md does not exist.
Skipping ./test/fixtures/simple because README.md does not exist.
Skipping ./test/setup because README.md does not exist.
➜  terraform-google-bootstrap git:(serviceusage-api-default) git status
On branch serviceusage-api-default
Your branch is up to date with 'origin/serviceusage-api-default'.

nothing to commit, working tree clean

It seems like the default values are not displayed for lists and maps in the generated docs

| Name | Description | Type | Default | Required |
| activate\_apis | List of APIs to enable in the seed project. | list(string) | `<list>` | no |

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, CI errors look spurious/unrelated.

@morgante morgante merged commit 71daed8 into terraform-google-modules:master Feb 7, 2020
@bdelv bdelv deleted the serviceusage-api-default branch February 10, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants