Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CloudBuild workspace blueprint #162

Merged
merged 15 commits into from
Jun 30, 2022
Merged

feat: CloudBuild workspace blueprint #162

merged 15 commits into from
Jun 30, 2022

Conversation

bharathkkb
Copy link
Member

This blueprint creates an opinionated workflow for actuating Terraform using Cloud Build.

daniel-cit
daniel-cit requested changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@daniel-cit daniel-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

There are some issues to address:

  • errors in cases of count/for_each in the context when the inputs used are create in the same configuration
  • adjustments in the README.md
  • adjustments in cloudbuild_sa usage

modules/tf_cloudbuild_workspace/buckets.tf Outdated Show resolved Hide resolved
modules/tf_cloudbuild_workspace/sa.tf Outdated Show resolved Hide resolved
modules/tf_cloudbuild_workspace/sa.tf Outdated Show resolved Hide resolved
modules/tf_cloudbuild_workspace/sa.tf Show resolved Hide resolved
modules/tf_cloudbuild_workspace/variables.tf Outdated Show resolved Hide resolved
modules/tf_cloudbuild_workspace/README.md Show resolved Hide resolved
modules/tf_cloudbuild_workspace/README.md Show resolved Hide resolved
modules/tf_cloudbuild_workspace/cb.tf Outdated Show resolved Hide resolved
modules/tf_cloudbuild_workspace/README.md Outdated Show resolved Hide resolved
@comment-bot-dev
Copy link

@bharathkkb
Thanks for the PR! 🚀
✅ Lint checks have passed.

daniel-cit
daniel-cit approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@daniel-cit daniel-cit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb bharathkkb merged commit bcbbed2 into master Jun 30, 2022
@bharathkkb bharathkkb deleted the workspace branch June 30, 2022 22:50
@release-please release-please bot mentioned this pull request Jun 30, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-cit daniel-cit daniel-cit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bharathkkb @comment-bot-dev @daniel-cit