Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to customize / upgrade terraform version #17

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

rjerrems
Copy link
Contributor

Solution to #16

@rjerrems
Copy link
Contributor Author

@morgante @ocervell - FYI looks like the build error is related to test our needing some clean up

ocervell
ocervell previously approved these changes Mar 19, 2020
Copy link
Contributor

@ocervell ocervell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick turnaround !

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really agree with this. The Dockerfile was already parameterized, why do we need to add a layer of indirection via Terraform?

@rjerrems
Copy link
Contributor Author

@morgante - This change allows people to customize the terraform version without having to fork the actual module to make there own copy, they can still use the CFT module from the registry / Github. Let me know if you think there is a better solution to allow this? It's very common for teams to use a specific version of terraform.

@morgante
Copy link
Contributor

Can't you simply override the env variables on the build to handle that, instead of introducing templating?

@rjerrems
Copy link
Contributor Author

So you would prefer we passed through the variables to the gcloud builds submit command? We could look into that, but it will end up functionally equivalent. If templating is flakier I am happy to investigate?

@morgante
Copy link
Contributor

Yeah I think that solution might be preferable. Templating locks this into Terraform, while the env-approach lets you easily copy the Dockerfile elsewhere if need be.

@rjerrems
Copy link
Contributor Author

I have updated now so that Cloud Build or Dockerfile can be used independently if people want and still paramaterize the versions using terraform variables. Let me know what you think @morgante

@rjerrems rjerrems force-pushed the custom-tf-version branch 2 times, most recently from 0779968 to 134225b Compare March 20, 2020 09:42
@rjerrems
Copy link
Contributor Author

@morgante - anything holding this back from merging now?

@morgante morgante merged commit b0a8474 into master Mar 25, 2020
@rjerrems rjerrems deleted the custom-tf-version branch August 8, 2020 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants