Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: option to target bootstrap module at a folder #40

Merged
merged 11 commits into from
Jul 6, 2020
Merged

feat: option to target bootstrap module at a folder #40

merged 11 commits into from
Jul 6, 2020

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Jul 2, 2020 •
edited

  • All bindings/roles are now applied at the folder level when possible when parent_folder is set.
    The following roles can only be applied at the org level and has not been changed.

    • roles/billing.creator
    • roles/billing.user
    • roles/billing.admin
    • roles/resourcemanager.organizationViewer
    • roles/orgpolicy.policyAdmin

  • Integration tests for folder mode

@bharathkkb bharathkkb changed the title Adds ability to target bootstrap module at a folder feat: option to target bootstrap module at a folder Jul 2, 2020
rjerrems
rjerrems reviewed Jul 3, 2020
View reviewed changes
main.tf Show resolved Hide resolved
rjerrems
rjerrems requested changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, just need to resolve the point about the dependency on project creators in a fresh org.

@bharathkkb bharathkkb requested a review from rjerrems July 3, 2020 09:14
rjerrems
rjerrems approved these changes Jul 5, 2020
View reviewed changes
Copy link
Contributor

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @bharathkkb

@rjerrems
Copy link
Contributor

rjerrems commented Jul 6, 2020

@morgante - do you have any idea why the tests appear incomplete when they have actually run through successfully?

@bharathkkb
Copy link
Member Author

@rjerrems there was a similar issue in the gke module
terraform-google-modules/terraform-google-kubernetes-engine#577 (comment)

@morgante morgante merged commit fa923a5 into master Jul 6, 2020
@morgante morgante deleted the folder-iam branch July 6, 2020 04:38
@rjerrems rjerrems mentioned this pull request Jul 6, 2020
Closed
@bharathkkb bharathkkb mentioned this pull request Jul 25, 2020
Closed
@release-please release-please bot mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjerrems rjerrems rjerrems approved these changes

@morgante morgante Awaiting requested review from morgante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bharathkkb @rjerrems @morgante