feat: Add ability to define custom list of branches to trigger apply … #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and custom cloudbuild YAML for terraform builds
morgante
approved these changes
Jul 6, 2020
morgante
pushed a commit
that referenced
this pull request
Jul 6, 2020
…and custom cloudbuild YAML for terraform builds (#41)
morgante
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
morgante
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to define a custom list of branches which trigger a terraform apply, to make it easier to build a workflow with the new code structure for the foundation example. I have also added an additional substitution for convenience when we eventually have a wrapper shell script.
The existing behavior should be preserved, although it will be using a slightly modified regex so we may need to flag the change as it will modify existing triggers.