feat: Add support for terraform validator #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjerrems
requested review from
morgante,
bharathkkb,
daniel-cit and
amandakarina
|
It looks like it is failing to delete the default network, which is likely due to this policy being applied across the org https://github.com/terraform-google-modules/terraform-example-foundation/blob/develop/1-org/envs/shared/org_policy.tf#L80 Our integration tests are currently scoped to a specific folder right @bharathkkb ? |
|
@rjerrems could you bump the provider in setup? it is is because of the org policy for not having default networks which was fixed in |
|
@morgante - it looks like the checks are not reporting as successful even though they were again? |
morgante
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add terraform-validator binary and git to the container image.