Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax tf version to allow 0.13 #67

Merged
merged 8 commits into from
Oct 22, 2020
Merged

feat: relax tf version to allow 0.13 #67

merged 8 commits into from
Oct 22, 2020

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Oct 20, 2020

  • relax version constraints
  • update inspec tests to 1.8
  • update pf

build/int.cloudbuild.yaml Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title [WIP] Test TF13 feat: relax tf version to allow 0.13 Oct 22, 2020
@bharathkkb
Copy link
Member Author

@rjerrems
Copy link
Contributor

rjerrems commented Oct 22, 2020

Thanks @bharathkkb - do you know why the integration tests are failing on the latest commit? I re-triggers and it seems to fail with the same inspec error:

     ×  Control Source Code Error /workspace/test/integration/cloudbuild_enabled/controls/gcp.rb:61 
     undefined method `split' for nil:NilClass

Is this because the inspec test have been upgraded perhaps?

@bharathkkb
Copy link
Member Author

bharathkkb commented Oct 22, 2020

@rjerrems we updated the gemfile in a later 0.13 image. Those changes were backported the 0.12.2 , so I have used that image now. A side effect is that I also had to regen docs with the new tfdocs 8b20542

Copy link
Contributor

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjerrems rjerrems merged commit af34b11 into master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants